Conversation
…tax (e.g. {}.function())
CommitlintThe following commit messages do not meet our commit convention. Please reword these commits for correct versioning and changelog generation.
|
| plugins: [ | ||
| new webpack.DefinePlugin({ | ||
| ASSETS_PATH: JSON.stringify(assets_url), | ||
| process: `{}` |
There was a problem hiding this comment.
There was a problem this caused (see the screenshot in the description of this pull request) and wrapping the curly braces like this fixed it. Testing didn't reveal any problems, but if anyone knows more about why this change was made (it was made here) and has concerns or knows what specifically to test for, let me know.
| font-family: 'Source Sans Pro', 'Segoe UI', Segoe, Calibri, Tahoma, | ||
| sans-serif; | ||
| font-family: | ||
| 'Source Sans Pro', 'Segoe UI', Segoe, Calibri, Tahoma, sans-serif; |
There was a problem hiding this comment.
This doesn't need to be updated with this PR, but the font should come from the theme, rather than being hard-coded.
|
I had thought we couldn't upgrade to React 19 in this library until our static front-end CDN supported ESM. Is that no longer the case @stevematney? Perhaps I misunderstood and the dependency is related to isolated-externals more than React 19? |
3 participants
EN-26992
The upgrade to React 19 resulted in a few different changes:
defaultPropsis no longer allowed on function components so those were removed.propTypesis deprecated but was only removed where it was causing problems to minimize the number of changes.react-datepickerexports its own types and changes were made to switch over to those. Further changes can and probably should be made to fully remove unnecessary code fromReactDatePickerPropTypes.ts.styleguide.config.jsthat replacesprocesswith{}was causing problems (see screenshot). Wrapping it in parenthesis, i.e.({}), fixed the problem and seems to not have re-introduced the issues that necessitated the configuration in the first place.